From 5837c1c7101fa32d39ed7be81f1409275354002d Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Thu, 5 Feb 2015 14:17:51 +0100 Subject: [PATCH] popover: Keep a ref on the parent scrollable This ensures the scrollable is still alive on dispose(), and properly unset after disconnecting all signal handlers. --- gtk/gtkpopover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c index 38dcf51638..c6afcfa29d 100644 --- a/gtk/gtkpopover.c +++ b/gtk/gtkpopover.c @@ -1591,12 +1591,15 @@ _gtk_popover_set_scrollable (GtkPopover *popover, g_object_unref (priv->hadj); priv->hadj = NULL; } + + g_object_unref (priv->parent_scrollable); } priv->parent_scrollable = scrollable; if (scrollable) { + g_object_ref (scrollable); priv->vadj = gtk_scrollable_get_vadjustment (scrollable); priv->hadj = gtk_scrollable_get_hadjustment (scrollable); -- 2.30.2